Update authentication keys #102
Merged
+261
−154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisli30
reviewed
Jan 15, 2025
aggregator/aggregator.go
Outdated
| @@ -51,7 +51,7 @@ const ( | |||
| func RunWithConfig(configPath string) error { | |||
| nodeConfig, err := config.NewConfig(configPath) | |||
| if err != nil { | |||
| panic(fmt.Errorf("failed to parse config file: %w\nMake sure %s is exist and a valid yaml file %w.", configPath, err)) | |||
| panic(fmt.Errorf("failed to parse config file: %s\nMake sure it is exist and a valid yaml file %w.", configPath, err)) | |||
There was a problem hiding this comment.
Let’s fix the capitalization now - the first letter of a sentence must be capitalized. Please fix other instances of fmt.Errorf() too.
Use Failed to, not failed to.
Do the below return return the message string to the gRPC client?
return fmt.Errorf("failed to parse config file: %s\nMake sure it is exist and a valid yaml file %w.", configPath, err)
There was a problem hiding this comment.
That is the error message when we run the aggregator from the command line during start-up. It isn't use for any gRPC client API.
chrisli30
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #97